Have `Qualified_name.try_parse` return a `Condition.t`

2 files changed, 8 insertions, 3 deletions

diff --git a/lib/qualified_name.ml b/lib/qualified_name.ml
index 47134c8..d69e866 100644
--- a/lib/qualified_name.ml
+++ b/lib/qualified_name.ml
@@ -13,6 +13,11 @@
 
 type t = { mg : string; name : string }
 
+module Error = struct
+  open Condition
+  let unqualified_name name = condition "unqualified-name" ("name" |=| (of_string name))
+end
+
 exception Unqualified of string
 
 let parse (s : string) : t =
@@ -24,8 +29,8 @@ let parse (s : string) : t =
       if mg = "" || name = "" then raise (Unqualified s)
       else { mg; name }
 
-let try_parse (s : string) : (t, string) result =
-  try Ok (parse s) with Unqualified s -> Error s
+let try_parse (s : string) : (t, Condition.t) result =
+  try Ok (parse s) with Unqualified s -> Error (Error.unqualified_name s)
 
 let make ~mg ~name = { mg; name }
 
diff --git a/lib/qualified_name.mli b/lib/qualified_name.mli
index 196dfbd..0e39ff2 100644
--- a/lib/qualified_name.mli
+++ b/lib/qualified_name.mli
@@ -11,7 +11,7 @@ val parse : string -> t
 (** Splits on the first [:].  Raises [Unqualified] when no mg segment is
     present (i.e. no colon, or empty mg / empty name). *)
 
-val try_parse : string -> (t, string) result
+val try_parse : string -> (t, Condition.t) result
 
 val make : mg:string -> name:string -> t