From 7ffd4d99bbb8e358c6694c27c7ff859967872ece Mon Sep 17 00:00:00 2001 From: Marcos Magueta Date: Sun, 10 May 2026 02:27:08 -0300 Subject: comparison to nt ob --- include/IdentityManager.h | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) (limited to 'include/IdentityManager.h') diff --git a/include/IdentityManager.h b/include/IdentityManager.h index 0e2d08f..5c8dd14 100644 --- a/include/IdentityManager.h +++ b/include/IdentityManager.h @@ -10,19 +10,37 @@ namespace nt { - /** @brief Checks whether an object supports identity-level operations. */ + /** + * @brief Checks whether an object supports identity-level operations. + * + * @todo Migrate to type callbacks. Once `object_type` holds `OpenProcedure` + * and `CloseProcedure` function pointers, CanOpen / CanClose become + * thin dispatchers that invoke the corresponding procedure — or this + * manager is absorbed into HandlerManager directly. The function pointer + * should be accompanied by a `const char* name` label on `object_type` + * so that error logs identify the type without dereferencing the pointer. + * See docs/reactos-ob-comparison.md §2. + */ class NT_API IdentityManager { public: /** - * @brief Looks into the methods of the object type and asserts if it can be opened. + * @brief Returns true when the object's type supports being opened. + * + * Currently checks that the object is non-null (stub). Should invoke + * `object_type::OpenProcedure` once callbacks are defined. + * * @param object Object to inspect. * @return True when the object can be opened. */ const bool CanOpen(ObjectManager::registry* object); /** - * @brief Checks whether an object can be closed. + * @brief Returns true when the object's type supports being closed. + * + * Currently checks that the object is non-null (stub). Should invoke + * `object_type::CloseProcedure` once callbacks are defined. + * * @param object Object to inspect. * @return True when the object can be closed. */ -- cgit v1.2.3